Posted: Mon Apr 27, 2009 12:04 pm Post subject: [asterisk-dev] [Code Review] New application JabberReceive,
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/88/#review749
-----------------------------------------------------------
There are a number of places throughout the rest of this function where the channel is not taken back out of autoservice when returning due to an error.
You call strlen(jid.screenname) and strlen(jid.resource) a couple of times in this loop. It will be more efficient to calculate it once outside of these loops and just used the saved off result.
The way this is written, it will check for a message, and if it doesn't find one, sleep for half a second before looking again.
Instead, the most elegant way to handle this would be to use a pthread lock and condition in combination with ast_pthread_cond_timedwait() and have the code receiving jabber messages wake up the thread if a matching message arrives before the timeout. That way, you don't needlessly loop through the messages multiple times while waiting, and you also will be able to continue immediately once the appropriate message arrives.
Let me know if you have any questions about my suggestion here.
While you're changing formatting of this line anyway, there should be a space after if.
- Russell
On 2009-04-17 09:18:26, Philippe Sultan wrote:
Quote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/88/
-----------------------------------------------------------
(Updated 2009-04-17 09:18:26)
Review request for Asterisk Developers.
Summary
-------
JabberReceive is a dialplan application that makes Asterisk wait for an XMPP message from a given user (identified with his JID), and store the content in a dialplan variable.
It can be used for example to notify a user (via XMPP) that a call is coming, and read input back from him.
Taken from the documentation :
In the following example, calls targeted to extension 1234 (be it
accessed from SIP, DAHDI or whatever channel type) are controlled by
user bob@jabber.org. Asterisk notifies him that a call is coming, and
asks him to take an action. This dialog takes place over an XMPP chat.
context from-ext {
1234 => {
Answer();
JabberSend(asterisk-xmpp,bob@jabber.org,Call from $CALLERID(num) - choose an option to process the call);
JabberSend(asterisk-xmpp,bob@jabber.org,1 : forward to cellphone);
JabberSend(asterisk-xmpp,bob@jabber.org,2 : forward to work phone);
JabberSend(asterisk-xmpp,bob@jabber.org,Default action : forward to your voicemail);
JabberReceive(bob@jabber.org,OPTION,20);
switch (${OPTION}) {
case 1:
JabberSend(asterisk-xmpp,bob@jabber.org,(Calling cellphone...);
Dial(SIP/987654321);
break;
case 2:
JabberSend(asterisk-xmpp,bob@jabber.org,(Calling workphone...);
Dial(SIP/${EXTEN});
break;
default:
Voicemail(${EXTEN}|u)
}
}
}
The diff also includes an implementation of SendText as XMPP messages in both chan_jingle and chan_gtalk.
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum